Improvements and clean-up for docs and help messages #3542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a reference to relative paths from documentation for the toolchain settings file. Relative paths were removed recently for security reasons.
|
Not sure what's going on with the macOS test failure. It seems unrelated, maybe it just randomly failed? |
djc
reviewed
Nov 24, 2023
|
Thanks! |
|
Done 👌 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed a reference to relative paths in
rust-toolchain.tomlfiles, as they're no longer supported for security reasons.I've also tried to improve the clarity and intuitiveness of several help messages, especially around profiles.
It got me thinking: could we rename the profile named "default" to "regular"? It's pretty confusing that there's a default profile and a "default" profile and your default profile doesn't have to be the "default" profile.