Update Dependencies & Bump to 1.11.0 #1355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets us atleast closer to not depending on winapi 0.2 anymore and we use some more consistent package versions...
|
@bors: r+ Thanks! The updates look great to me and I think it's fine to hold off on the upgrades for another version |
|
📌 Commit 745cf43 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 13, 2018
Update Dependencies & Bump to 1.11.0 This makes proper architecture (=faster) windows builds available for **1.12.0**. I sneaked some version updates in to ensure that we're a step closer to a consistent state on that front. Some open points: - [ ] 1. Should we add a special case to self_update which makes the windows fixes available on **1.11.0** (this) already? e.g. hardcoding the version [somewhere](https://github.com/rust-lang-nursery/rustup.rs/blob/0068f0999acb923428cbd709650c57fbe04a0344/src/rustup-cli/self_update.rs#L1497) in the windows update logic introducted. This potentially could lead to infinite looping, if we're not careful. - [ ] 2. Any objections against the updates? Splitting them into a separate PR would be fine. (Not sure if CI even passes at this point, but we'll see) r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
|
Deployed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes proper architecture (=faster) windows builds available for 1.12.0.
I sneaked some version updates in to ensure that we're a step closer
to a consistent state on that front.
Some open points:
makes the windows fixes available on 1.11.0 (this) already?
e.g. hardcoding the version somewhere in the windows update logic introducted.
This potentially could lead to infinite looping, if we're not careful.
(Not sure if CI even passes at this point, but we'll see)
r? @alexcrichton