8000 feat(self_update): add proxy sanity checks by manyinsects · Pull Request #4338 · rust-lang/rustup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(self_update): add proxy sanity checks #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(self_update): add proxy sanity checks #4338

wants to merge 1 commit into from
+31 −0

Conversation

manyinsects
Copy link
Member
@manyinsects manyinsects commented May 17, 2025 •
edited
Loading

Sometimes, proxies can be incorrectly installed for whatever reason. This adds a new check after initial component installation to call all proxies with --version, and to fail if one of them doesn't report success.

Closes #4336 (but there should probably be a followup issue for potentially self-repairing broken proxies?).

There are two test failures in my local testing: this has been resolved (for now...?) by limiting to only core components

rami3l
rami3l reviewed May 17, 2025
View reviewed changes
rami3l
rami3l requested changes May 17, 2025
View reviewed changes
Copy link
Member
@rami3l rami3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad for the first PR, thanks a lot :)

The existing error messages might indicate that the default toolchain is unset in certain situations, so instead of calling <bin> --version, maybe call <bin> +<toolchain> --version?

@manyinsects manyinsects force-pushed the proxy-sanity-checks branch 2 times, most recently from 4aba99b to 780a1e1 Compare May 17, 2025 18:01
@manyinsects
feat(self_update): add proxy sanity checks
eb1b8c8 
Sometimes, proxies can be incorrectly installed for whatever
reason. This adds a new check after initial component
installation to call all proxies with --version, and to
fail if one of them doesn't report success.
@manyinsects manyinsects force-pushed the proxy-sanity-checks branch from 780a1e1 to eb1b8c8 Compare May 17, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l rami3l requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanity check for proxies created during the installation phase
2 participants
@manyinsects @rami3l
0