8000 fix: Support spans with proc macro servers from before the ast id changes by ChayimFriedman2 · Pull Request #19985 · rust-lang/rust-analyzer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Support spans with proc macro servers from before the ast id changes #19985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

fix: Support spans with proc macro servers from before the ast id changes #19985

merged 1 commit into from
Jun 12, 2025

Conversation

ChayimFriedman2
Copy link
Contributor
@ChayimFriedman2 ChayimFriedman2 commented Jun 12, 2025 •
edited by rustbot
Loading

The only thing changed is the value of the fixup ast id, so we just swap it.

As @Veykril suggested in #19837.

This brings unknown types back to normal.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2025
Veykril
Veykril reviewed Jun 12, 2025
View reviewed changes
@ChayimFriedman2
Support spans with proc macro servers from before the ast id changes
3e834ad 
The only thing changed is the value of the fixup ast id, so we just swap it.
@ChayimFriedman2 ChayimFriedman2 force-pushed the proc-macro-srv-ast-id branch from 4077ea0 to 3e834ad Compare June 12, 2025 13:08
@Veykril Veykril added this pull request to the merge queue Jun 12, 2025
Merged via the queue into rust-lang:master with commit 87f99c7 Jun 12, 2025
14 checks passed
@ChayimFriedman2 ChayimFriedman2 deleted the proc-macro-srv-ast-id branch June 12, 2025 13:49
@ChayimFriedman2
Copy link
Contributor Author

@Veykril it's probably good to release a new nightly of r-a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChayimFriedman2 @Veykril @rustbot
0