ItemTree's ItemVisibilities has no identity, so deduplicate
#19980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b684ba8 to
5996add
Compare
ChayimFriedman2
requested changes
Jun 12, 2025
crates/hir-def/src/item_tree.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| #[derive(Default, Debug, Eq, PartialEq)] | ||
| struct ItemVisibilities { | ||
| arena: Arena<RawVisibility>, | ||
| // `IndexSet`` is *big*, but we seldom have `in path` visibilities, so be lazy about it | ||
| set: Option<Box<IndexSet<RawVisibility>>>, |
There was a problem hiding this comment.
Should use FxIndexSet.
There was a problem hiding this comment.
We probably need to add it to clippy's disallowed-types.
There was a problem hiding this comment.
Also, can't we use IndexSet just during construction, then point them all to the same visibility in the Arena?
There was a problem hiding this comment.
Ah right (why did my clippy not lint that 🤔)
There was a problem hiding this comment.
We probably need to add it to clippy's disallowed-types.
Right that only lits the std types
088c65e to
319193f
Compare
319193f to
13494f4
Compare
ChayimFriedman2
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely not noticable, as barely anyone uses
pub(in path)visibilities