fix: Fix postfix snippets duplicating derefs #19764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the proper fix here is to also consider the type adjustments of the receiver. As |
|
Adjustments depend on the method invoked, so we cannot know them. |
|
Oh right, sorry, I meant the adjustments of a parent field access / method call expression in cases like But that's a separate concern, mixed up the problems here |
Veykril
approved these changes
May 8, 2025
|
I think this will be pretty hard to achieve because inference is done on |
|
Ye that would require even more speculative execution I think 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19758.
I'm not entirely sure the
found_ref_or_derefcheck is correct - I think maybe we should remove it - but removing it makesletpostfix completions no longer appear (although I suspect this is because we check the grandparent instead of the parent).