feat: Add pumpkin_solver solver
#96
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(pumpkin-solver): add Pumpkin solver integration to Cargo features and solvers * build(pumpkin): add conditional compilation directives * fix: typo * build: cargo build success 🎉 * build: cargo builds again * fix: cargo builds 🎉 (2 unused warnings) * fix: new try * fix: solve simple problem test pass * test: solve easy and solve milp passing 🎉 * fix: tests were passing for the wrong reasons * fix(temporary): unsure how to set objective bounds properly, hotfix [-1000, +1000]
pumpkin_solver solver (#1)pumpkin_solver solver
This was referenced Mar 16, 2025
lovasoa
requested changes
Mar 17, 2025
|
You also need to update the CI to test the new solver: https://github.com/rust-or/good_lp/blob/main/.github/workflows/rust.yml |
|
Thanks a lot, I added pumpkin-solver* to the table with a no on the WASM box but I am not actually sure if that is something that needs special support or if you get it out of the box via
*I feel like pumpkin would be a nicer feature name but I don’t know if it’s preferable to keep it exactly the same as the crate name… I’ll try using it with existing good_lp code and see if I can road test it this week, add those missing tests and try to find a solution to the objective var bounds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m not sure about a couple of things here:
TODO
cargo test --no-default-features --features pumpkin-solvershould pass[-1000, +1000]hotfix)