ci: Add doctests to rust.yml #626
Conversation
There was a problem hiding this comment.
Maybe it makes sense to integrate the .github/workflow/ changes recently done here:
rust-bio/rust-htslib#465
it seems like these are using the latest version of things that are actively maintained.
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Applied these changes (listing seems to fail now?) and also removed the added doctest step nut added |
| # with: | ||
| # submodules: recursive | ||
|
|
||
| # - name: Install nightly toolchain | ||
| # uses: actions-rs/toolchain@v1 | ||
| # uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
I think we should also update the below tarpaulin code, even though it is currently commented out. Thus, once we turn it back on, it will have the newer setup already; so fewer things to fix at that point, I would hope.
We could even try to turn this back on, now. Doesn't seem like the above-linked issue is resolved, though.
There was a problem hiding this comment.
What exactly would you want to update there?
There was a problem hiding this comment.
Sorry, that wasn't really clear. The changes that you can see here:
There was a problem hiding this comment.
Ok lets see if it it works 🤞 Otherwise lets comment it out again.
There was a problem hiding this comment.
Just commented it back out. Let's see.
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
|
@dlaehnemann So I quickly tried the nightly toolchain for linting but it still has massive problems. No idea why these issues haven't been there before. |
This pull request includes changes to the GitHub Actions workflow configuration for rust-bio. It adds a step to the action that runs the doctests.