8000 feat: added parser for bionano custom file formats by laurakuehle · Pull Request #603 · rust-bio/rust-bio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: added parser for bionano custom file formats #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

laurakuehle
Copy link

No description provided.

@laurakuehle laurakuehle changed the title Added parser for Bionano custom file formats. feat: added parser for bionano custom file formats Sep 12, 2024
src/io/cmap.rs Outdated
Comment on lines 66 to 72
pub struct Record {
id: u32,
len: f64,
num_labels: u32,
label_channel: u8,
labels: Vec<Label>,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does a cmap record not have a contig name?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no contig names in CMAPs; they are identified solely by their integer ID.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Where are the contig names stored then?

Copy link
Author
@laurakuehle laurakuehle 8000 Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nowhere. Bionano formats do not have any contig names and do not seem to support them at all.
If you convert a FASTA (with existing contig names) to a CMAP, you could store this information separately and integrate it later on if desired. Note that this will only work if you do not use a reference already in CMAP format, unlike the ones Bionano or FaNDOM provide, so this is not universally applicable.
For OM2DNA, I have always used CMAPs converted from FASTAs though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the .fai of the fasta is the right source.

@johanneskoester johanneskoester marked this pull request as draft September 24, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0