Remove the hex dependency #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37b1ab8 to
865d4ae
Compare
|
This won't work until rust-bitcoin/bitcoin_hashes#71 will get merged because the |
|
Now that rust-bitcoin/bitcoin_hashes#71 is merged this should is mergeable. |
865d4ae to
610174b
Compare
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 85.15% 85.66% +0.51%
==========================================
Files 40 40
Lines 7478 7745 +267
==========================================
+ Hits 6368 6635 +267
Misses 1110 1110
Continue to review full report at Codecov.
|
stevenroose
reviewed
Jan 20, 2020
| @@ -84,7 +84,7 @@ fn bitcoin_genesis_tx() -> Transaction { | |||
|
|
|||
| // Outputs | |||
| let out_script = script::Builder::new() | |||
| .push_slice(&Vec::<u8>::from_hex("04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5f").unwrap()) | |||
There was a problem hiding this comment.
Ah that's really cool :) I guess Vec<u8> is the only vec FromHex is defined on?
There was a problem hiding this comment.
It wouldn't make much sense on any other Vec :) (without getting into endianness lol )
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
We manually implement a bunch of traits on `Miniscript` that pass through to the `node` field (e.g. `PartialEq`). We should do the same for `hash::Hash` instead of deriving it. Found by clippy. Fixes: rust-bitcoin#381
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
…script 4ac68c9 Implement hash::Hash for Miniscript (Tobin C. Harding) Pull request description: We manually implement a bunch of traits on `Miniscript` that pass through to the `node` field (e.g. `PartialEq`). We should do the same for `hash::Hash` instead of deriving it. Found by clippy. Fixes: rust-bitcoin#381 ACKs for top commit: apoelstra: ACK 4ac68c9 Tree-SHA512: 7920481034bee12fbfdbdfac2f38e9598e25a13a8a89b6b50cc7f63ce528c2de47e959ad073ac1c8f1ab64d4b0e432d264a5caf74ddb656c1a0ffbd8923faf6f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the hex dependecy from the tests.
I had to leave the
hex_hash!macro because here https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/util/bip143.rs#L143 I needed to use that instead ofSigHash::from_hexbecause the latter requires the hex to be in reverse ordering.FYI currently even non tests will build
hexbecause of#[cfg(any(test, feature = "serde"))] extern crate hex;This is no longer true as of rust-bitcoin/bitcoin_hashes#71(I confued myself. even though the hex crate isn't used in non-test code it is still compiled and linked for that reason)Closes #332