Remove tempfile as a dependency #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
apoelstra
reviewed
Aug 5, 2019
1bc45a5 to
22e625d
Compare
Removed tempfile usage from stream_reader
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 81.71% 81.72% +0.01%
==========================================
Files 38 38
Lines 6825 6808 -17
==========================================
- Hits 5577 5564 -13
+ Misses 1248 1244 -4
Continue to review full report at Codecov.
|
apoelstra
approved these changes
Aug 5, 2019
tamasblummer
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
tempfileas a dependency.it wasn't really needed anyway, anything that was done via the fs can be done with in memory buffers.
this solves #306 and #305