8000 bip32: Add increment method to DerivationPath and ChildNumber by stevenroose · Pull Request #257 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bip32: Add increment method to DerivationPath and ChildNumber #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2019
Merged

bip32: Add increment method to DerivationPath and ChildNumber #257

merged 1 commit into from
May 4, 2019

Conversation

stevenroose
Copy link
Collaborator

No description provided.

@stevenroose stevenroose requested a review from dongcarl April 26, 2019 14:28
sgeisler
sgeisler reviewed Apr 27, 2019
View reviewed changes
@apoelstra
Copy link
Member

Looks good! But can you remove the increment commit? :)

@stevenroose
Copy link
Collaborator Author

Sure I can squash them.

@stevenroose stevenroose force-pushed the bip32-increment branch from 4a7d334 to bb85202 Compare May 3, 2019 16:55
8000
@stevenroose
Copy link
Collaborator Author

Squashed.

@stevenroose
bip32: Add DerivationPathIterator and related methods
bb85202 
Adds methods
- ChildNumber::increment
- DerivationPath::children_from
- DerivationPath::normal_children
- DerivationPath::hardened_children
@apoelstra apoelstra self-requested a review May 3, 2019 17:26
apoelstra
apoelstra approved these changes May 3, 2019
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Trusting CI to catch any compilation errors.

sgeisler
sgeisler approved these changes May 4, 2019
View reviewed changes
Copy link
Contributor
@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@apoelstra
Copy link
Member

For the record, I had meant to actually remove the increment function rather than squashing the commits together. But ok, it's not like it's hurting anything :)

@apoelstra apoelstra merged commit b471a12 into rust-bitcoin:master May 4, 2019
casey pushed a commit to casey/rust-bitcoin that referenced this pull request Nov 28, 2023
@apoelstra
Merge rust-bitcoin/rust-bitcoincore-rpc#258: cargo +nightly fmt --che…
d274dce 
…ck --all

13bd5d3 cargo fmt (thesimplekid)

Pull request description:

  Saw you merged rust-bitcoin#257 but figured I would run format all as you mentioned anyway.
  rust-bitcoin/rust-bitcoincore-rpc#257 (comment)

ACKs for top commit:
  apoelstra:
    ACK 13bd5d3

Tree-SHA512: b2dc500fc036a763a77a7340b528a5973b62d44a672bb4d0fd3bc1c42a66886d77d92f159fa8897fa037b6988f918e36174633de93dfaed19a03c3f4517c91c0
yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this pull request Mar 23, 2024
@apoelstra
Merge pull request rust-bitcoin#257 from sanket1729/type_bug
37ad4ff 
fix miniscript typesystem bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sgeisler sgeisler sgeisler approved these changes

@dongcarl dongcarl Awaiting requested review from dongcarl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenroose @apoelstra @sgeisler
0