-
Notifications
You must be signed in to change notification settings - Fork 831
bump version to 0.17.0 #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's in this or previous release. But the PR adding derivation path parsing got merged recently. Might be worth mentioning.
It's in this release, the "BIP32 cleanup" link goes to it. Should I reword that? Also @TheBlueMatt I'd like your ACK on this. |
Ah was in mobile. Nah I guess that's fine.
…On Thu, Feb 28, 2019, 23:23 Andrew Poelstra ***@***.*** wrote:
It's in this release, the "BIP32 cleanup" link goes to it. Should I reword
that?
Also @TheBlueMatt <https://github.com/TheBlueMatt> I'd like your ACK on
this.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#239 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0F3HNkqX4u1If9DFryfR1D9tUWlckrks5vSGTcgaJpZM4bX1Me>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry been kinda MIA of late given other projects, but I dont have any opposition to this in principle.
* [Clean up BIP32](https://github.com/rust-bitcoin/rust-bitcoin/pull/233) in preparation for PSBT; [use new native key types rather than `secp256k1` ones](https://github.com/rust-bitcoin/rust-bitcoin/pull/238/) | ||
* Remove [apparently-used `Option` serialization](https://github.com/rust-bitcoin/rust-bitcoin/pull/236#event-2158116421) code | ||
* Finally merge [PSBT](https://github.com/rust-bitcoin/rust-bitcoin/pull/103) after nearly nine months | ||
|
||
# 0.16.0 - 2019-01-15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me suggest adding to the list a recently merged PR for serialization for a network stream: #231
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good now?
export ConversionError
No description provided.