8000 Internalize unnecessarily exported macros by dongcarl · Pull Request #211 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Internalize unnecessarily exported macros #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2019
Merged

Internalize unnecessarily exported macros #211

merged 1 commit into from
Jan 15, 2019

Conversation

dongcarl
Copy link
Member
@dongcarl dongcarl commented Jan 15, 2019 •
edited
Loading

user_enum didn't need to be exported as per IRC convo.

@dongcarl dongcarl force-pushed the 2019-01-move-user-enum-macro branch from c88fd50 to b2e044f Compare January 15, 2019 16:55
@dongcarl dongcarl changed the title Move user_enum macro to internal_macros Internalize unnecessarily exported macros Jan 15, 2019
sgeisler
sgeisler approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor
@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dongcarl, looks good, I restarted the stable test because the fuzzer found the serde overflow again (I think we might be able to fix this after bumping the min. rust version).

@TheBlueMatt TheBlueMatt merged commit 81bfc4f into rust-bitcoin:master Jan 15, 2019
@dongcarl dongcarl mentioned this pull request Jan 15, 2019
Merged
yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this pull request Mar 23, 2024
@sanket1729
Merge pull request rust-bitcoin#211 from sanket1729/doc
fea9455 
Fix incorrect doc links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

@sgeisler sgeisler sgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dongcarl @TheBlueMatt @sgeisler
0