8000 Update base64 usage to 0.21.3 by junderw · Pull Request #2032 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update base64 usage to 0.21.3 #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2023
Merged

Update base64 usage to 0.21.3 #2032

merged 1 commit into from
Sep 2, 2023

Conversation

junderw
Copy link
Contributor
@junderw junderw commented Aug 28, 2023

Closes #2031

The imports are a bit bike-sheddy... but I think this is fine.

@junderw junderw force-pushed the junderw/update-base64 branch from d3eb7b5 to b5f64be Compare August 28, 2023 00:07
tcharding
tcharding reviewed Aug 28, 2023
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You the man, I only raised that issue a couple of hours ago, thanks!

@junderw junderw force-pushed the junderw/update-base64 branch from d400d14 to f77f207 Compare August 28, 2023 04:10
@junderw
Copy link
Contributor Author
junderw commented Aug 28, 2023
8000

I fixed the issues you mentioned, and consolidated the base64 impls (since there were a bunch of cfg for it).

I also built the docs and made sure that doc_auto_cfg still marked them as feature gated on base64 and it worked.

@tcharding
Copy link
Member

Needs use crate::prelude::String mate.

@junderw junderw force-pushed the junderw/update-base64 branch 2 times, most recently from 850c18e to c5b85d7 Compare August 28, 2023 08:59
tcharding
tcharding reviewed Aug 28, 2023
View reviewed changes
@junderw junderw force-pushed the junderw/update-base64 branch from c5b85d7 to b7de2aa Compare August 29, 2023 01:33
@junderw
Copy link
Contributor Author
junderw commented Aug 29, 2023

Fixed 👍

@junderw junderw force-pushed the junderw/update-base64 branch from 0e44db5 to 8aee25b Compare August 29, 2023 02:09
tcharding
tcharding approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b7de2aa991d9110aabe2b0233142857144d5da18

@tcharding
Copy link
Member

The CI fail is memchr breaking our MSRV, I'll fix that.

@junderw junderw force-pushed the junderw/update-base64 branch from b7de2aa to 0e44db5 Compare August 29, 2023 02:27
@tcharding
Copy link
Member

Needs #2036

@junderw
Copy link
Contributor Author
junderw commented Aug 29, 2023

The life of a lower MSRV library crate..........

@tcharding
Copy link
Member

Tell me about it :)

@junderw junderw force-pushed the junderw/update-base64 branch from 8aee25b to 18e2854 Compare August 31, 2023 05:48
@junderw
Copy link
Contributor Author
junderw commented Aug 31, 2023 •
edited
Loading

Rebased on master. (All tests pass 🎉)

tcharding
tcharding approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 18e2854

RCasatta
RCasatta reviewed Aug 31, 2023
View reviewed changes
@RCasatta RCasatta mentioned this pull request Aug 31, 2023
Open
apoelstra
apoelstra approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 18e2854

@apoelstra apoelstra merged commit 1cb5cb7 into rust-bitcoin:master Sep 2, 2023
@junderw junderw deleted the junderw/update-base64 branch September 2, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCasatta RCasatta RCasatta left review comments

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade base64 dependency
4 participants
@junderw @tcharding @apoelstra @RCasatta
0