Add version bytes consts #2020
Merged
Add version bytes consts #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BIP-32 defines 4 4-byte consts used as version bytes; currently we are hardcoding the version bytes in multiple places. Add BIP-32 version bytes consts and use them throughout the module.
apoelstra
approved these changes
Aug 22, 2023
|
LGTM |
RCasatta
approved these changes
Aug 25, 2023
apoelstra
added a commit
that referenced
this pull request
Oct 27, 2023
2a891e0 Add a missing link to #2006 in 'bitcoin/CHANGELOG.md' (lateminer) Pull request description: In the changelog, there is a wrong link to #2006. Additionally, a link and description for #2020 are missing. This PR addresses these minor issues. ACKs for top commit: apoelstra: ACK 2a891e0 tcharding: ACK 2a891e0 Tree-SHA512: c6dc1362af5bb2e5f11c2ed48371a0236ab512aeb0f6075674994c054baf606d9cf30390d7021f9c02c3b7cc59a70c60edb64799afb35cc5ac716a3582aa8cd0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIP-32 defines 4 4-byte consts used as version bytes; currently we are hardcoding the version bytes in multiple places.
Add BIP-32 version bytes consts and use them throughout the module.