Export all hash types #1988
Export all hash types #1988
Conversation
|
cc @stevenroose because I closed #1792 and re-did it here. |
|
So we don't forget it, in the other thread, @Kixunil registered a concept NACK on this on the basis that it would clutter the documentation. I pushed back on this but I don't believe we came to an agreement. For my part, I think these should exist and don't perceive very much documentation clutter in a long list of "Re-exports" which have their own section and are visually distinct from real things. I'm happy to bring them back for now, and we can discuss this again in the future. Including considering doing hacky things like |
|
Yes I think we should accept that we have not got the re-exports (and the public API surface) exactly as we want it and don't know exactly what that is yet - we should not break downstream with half thought out changes. (That was all me by the way.) |
During the 0.30.0 release we removed the re-exports of hash types. This upset some folk and since the aim of our re-exports is not exactly clean as well as the fact that the public API surface is not yet fixed just re-export all the hash types at the crate root again. This is 1792 but does not use a wildcard and also grabs the other hashes that we recently moved.
3a0b631 to
7bbdd9b
Compare
|
This PR is a candidate for bikeshedding but at its core is super trivial. IMO it qualifies for the one-ack carve-out, if no one comments or nacks please consider for merge after the 25th of August. |
During the 0.30.0 release we removed the re-exports of hash types. This upset some folk and since the aim of our re-exports is not exactly clean as well as the fact that the public API surface is not yet fixed just re-export all the hash types at the crate root again.
This is #1792 but does not use a wildcard and also grabs the other hashes that we recently moved.