8000 update proc-macro to 1.0.56 to 1.0.63 by apoelstra · Pull Request #1927 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update proc-macro to 1.0.56 to 1.0.63 #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2023
Merged

update proc-macro to 1.0.56 to 1.0.63 #1927

merged 1 commit into from
Jul 7, 2023

Conversation

apoelstra
Copy link
Member

1.0.56 does not compile on Rust nightly anymore.

@apoelstra
update proc-macro to 1.0.56 to 1.0.63
c958112 
1.0.56 does not compile on Rust nightly anymore.
@apoelstra apoelstra mentioned this pull request Jun 29, 2023
Merged
tcharding
tcharding approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider only using the recent lock file for nightly tests for similar but opposite reasons to why I made MSRV only use minimal one i.e., if does not make a lot of sense to use a nightly toolchain with really old dependencies.

ce21bf2

But ACK c958112

@apoelstra
Copy link
Member Author

The dependencies in the lockfile are supposed to reflect ones that we've vetted. I don't think we should change that just because the Rust compiler sometimes has breaking changes.

@yancyribbens
Copy link
Contributor

ACK c958112

tested locally also by overwriting Cargo.lock with Cargo-minimal.lock and building nightly

adoerr
adoerr approved these changes Jul 3, 2023
View reviewed changes
Copy link
@adoerr adoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c958112

sanket1729
sanket1729 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member
@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c958112

@apoelstra apoelstra merged commit 1318ff8 into master Jul 7, 2023
@apoelstra apoelstra deleted the 2023-06--fix-nightly branch July 7, 2023 18:44
This was referenced Jul 8, 2023
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanket1729 sanket1729 sanket1729 approved these changes

@adoerr adoerr adoerr approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apoelstra @yancyribbens @sanket1729 @adoerr @tcharding
0