8000 Add `ValidationError` by tcharding · Pull Request #1874 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ValidationError #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2023
Merged

Add ValidationError #1874

merged 3 commits into from
May 28, 2023

Conversation

tcharding
Copy link
Member

Remove the crate::Error and replace its usage with block::ValidationError.

tcharding added 3 commits May 25, 2023 13:32
@tcharding
Move BlockHash From impls 8000
3a9b552 
Move the `From` impls on `BlockHash` to below the `BlockHash` impl
block.

Code move only, no other changes.
@tcharding
Add block::ValidationError
74154c2 
Add a `ValidationError` to the `block` module and remove the two
variants out of `crate::Error`.

This error is only used by the `validate_pow` function, a specific error
better serves our purposes.
@tcharding
Remove the unused crate::Error
0f74eb6 
The `crate::Error` type is now unused, remove it.
apoelstra
apoelstra approved these changes May 25, 2023
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0f74eb6

Kixunil
Kixunil approved these changes May 28, 2023
View reviewed changes
Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0f74eb6

@apoelstra apoelstra merged commit 5729b03 into rust-bitcoin:master May 28, 2023
@tcharding tcharding deleted the 05-24-bitcoin-error branch May 30, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcharding @Kixunil @apoelstra
0