Removed only available in 1.46.0 line #1863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use the form "Fix: #1850" github will autoclose the issue if/when this PR merges.
This is not a correct description of the PR, the PR makes two changes. Here is blog post that I have found educational to learn how to describe code changes in a way that helps reviewers and helps you get your changes merged: https://cbea.ms/git-commit/ |
What is the other one? It removes two such lines, not one, but it's not a big deal. |
Kixunil
approved these changes
May 19, 2023
|
@tcharding Thank you sir for the review. I will edit the pr message according to what you suggested. |
|
Ack 6a18997 |
apoelstra
approved these changes
May 19, 2023
tcharding
approved these changes
Jun 6, 2023
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1850
Removed "Important: only available in Rust 1.46+" on the file transaction.rs from lines 1288 and 1407 respectively.