8000 feat: generate PrivateKey by kshitjj · Pull Request #1837 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: generate PrivateKey #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2023
Merged

feat: generate PrivateKey #1837

merged 1 commit into from
May 8, 2023

Conversation

kshitjj
Copy link
Contributor
@kshitjj kshitjj commented May 4, 2023

added a function to generate a private key

Resolves: #1823

sanket1729
sanket1729 reviewed May 4, 2023
View reviewed changes
Kixunil
Kixunil reviewed May 4, 2023
View reviewed changes
Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method looks good.

@sanket1729
Copy link
Member

Can you squash everything into a single commit?

@kshitjj
Copy link
Contributor Author
kshitjj commented May 4, 2023 •
edited
Loading

Hey @sanket1729, I have squashed everything into a single commit.

@kshitjj kshitjj force-pushed the generate-PrivateKey branch 2 times, most recently from a7f13e1 to cb71073 Compare May 5, 2023 15:21
tcharding
tcharding reviewed May 5, 2023
View reviewed changes
@Kixunil
Copy link
Collaborator
Kixunil commented May 7, 2023

You will need to squash again since we require that every commit passes test suite.
< 8000 input type="hidden" name="_method" value="put" autocomplete="off" />

@kshitjj kshitjj force-pushed the generate-PrivateKey branch from bf1a3a5 to 995c797 Compare May 7, 2023 16:27
@kshitjj
Copy link
Contributor Author
kshitjj commented May 7, 2023 •
edited
Loading

@Kixunil I have squashed everything, and ran the githooks before the submitting commit. PR is good to go!

@junderw
Copy link
Contributor
junderw commented May 7, 2023

Perhaps it should add the docsrs feature gate on generate?

#[cfg_attr(docsrs, doc(cfg(feature = "rand-std")))]

@apoelstra
Copy link
Member

@junderw we don't need to explicitlly tag methods for docsrs anymore thanks to doc_auto_cfg in lib.rs.

apoelstra
apoelstra approved these changes May 7, 2023
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 995c797

tcharding
tcharding approved these changes May 8, 2023
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man!

ACK 995c797

@apoelstra apoelstra merged commit dea6282 into rust-bitcoin:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil left review comments

@sanket1729 sanket1729 sanket1729 left review comments

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PrivateKey is annoying to generate
6 participants
@kshitjj @sanket1729 @Kixunil @junderw @apoelstra @tcharding
0