8000 remove Lines of Code badge by Harshil-Jani · Pull Request #1734 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove Lines of Code badge #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2023
Merged

remove Lines of Code badge #1734

merged 1 commit into from
Mar 22, 2023

Conversation

Harshil-Jani
Copy link
Contributor

closes #1727

@Harshil-Jani
remove Lines of Code badge
450df18 
Signed-off-by: Harshil Jani <harshiljani2002@gmail.com>
Kixunil
Kixunil approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 450df18

Thanks!

@Kixunil Kixunil added documentation trivial Obvious, easy and quick to review (few lines or doc-only...) labels Mar 22, 2023
apoelstra
apoelstra approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 450df18

tcharding
tcharding approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No badge is better than 0 badge but a working badge would have been even better :)

Oh I just saw the suggestion to remove it from the others, ignore me.

@tcharding
Copy link
Member

ACK 450df18

@apoelstra apoelstra merged commit 136d577 into rust-bitcoin:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LoC badge does not work
4 participants
@Harshil-Jani @tcharding @Kixunil @apoelstra
0