8000 Improve downflow of information in `psbt::Error` by nph4rd · Pull Request #1591 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve downflow of information in psbt::Error #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2023
Merged

Improve downflow of information in psbt::Error #1591

merged 1 commit into from
Jan 26, 2023

Conversation

nph4rd
Copy link
Contributor
@nph4rd nph4rd commented Jan 24, 2023 •
edited
Loading

See third point in #837

Closes: #1589

@nph4rd
Copy link
Contributor Author
nph4rd commented Jan 24, 2023

@DanGould - here's the last bit :)

apoelstra
apoelstra reviewed Jan 24, 2023
View reviewed changes
apoelstra
apoelstra reviewed Jan 24, 2023
View reviewed changes
@nph4rd nph4rd force-pushed the improve-psbt-error branch from 36f056a to 99278a5 Compare January 24, 2023 20:44
@nph4rd
Copy link
Contributor Author
nph4rd commented Jan 24, 2023

Force-pushed 99278a5 to address comments. Specifically:

  • Replace Taproot with InvalidLeafVersion - comment.
  • Remove Error suffix from TaprootError - comment
  • Split InvalidPublicKey into InvalidPublicKey and InvalidSecp256k1PublicKey and split InvalidSignature into InvalidEcdsaSignature and InvalidSchnorrSignature. All now hold the corresponding error - comment

PS - I'm not sure what's up with the tests. They ran fine locally. I ran ./contrib/test.sh and it worked OK. I also used both stable and 1.47.0 RVs and the tests seemed fine 🤔 Could it be GitHub, or am I missing something?

@nph4rd nph4rd requested a review from apoelstra January 24, 2023 21:24
@apoelstra
Copy link
Member

Can you try cargo test --verbose --features=no-std --no-default-features locally?

@nph4rd nph4rd force-pushed the improve-psbt-error branch from 99278a5 to 68abfdb Compare January 24, 2023 21:49
@nph4rd
Copy link
Contributor Author
nph4rd commented Jan 24, 2023

Can you try cargo test --verbose --features=no-std --no-default-features locally?

Ah - that was it. Pushed 68abfdb with fix.

Thanks for that! :)

@apoelstra
Copy link
Member

This looks great! There's still some work to be done on these errors but this is a big improvement, and I think further changes may need to wait until crate smashing has settled out a bit.

apoelstra
apoelstra approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 68abfdb

tcharding
tcharding approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 68abfdb

@nph4rd nph4rd mentioned this pull request Jan 26, 2023
Merged
@apoelstra apoelstra merged commit f903380 into rust-bitcoin:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use explicit psbt::Error types instad of ParseError(String) messages to downflow information
3 participants
@nph4rd @apoelstra @tcharding
0