Use sha256d::Hash type for sighash encoding
#1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
previously approved these changes
Jan 20, 2023
|
Oh I just saw your comment @apoelstra, I'll revisit this. #1549 (comment) |
`Sighash` does not need to implement `Encodable` because it is claimed (I don't know exactly myself) that `Sighash` is never consensus encode in Bitcoin. We are currently relying on `Sighash` to implement `Encodable` when encoding creating the segwit v0 sighash for a single input. For reference, from BIP143: If sighash type is SINGLE and the input index is smaller than the number of outputs, hashOutputs is the double SHA256 of the output amount with scriptPubKey of the same index as the input; We can use `write_all` directly to write the hashed bytes and remove the implementation of `Encodable` from the `Sighash` type. While we are at it, use `write_all` to write the zero hash also to make the code more uniform and understandable. Fix: rust-bitcoin#1549
895fb6e to
49e8b8d
Compare
|
Re-wrote to use suggestions from the issue. Note I use the phrase "it is claimed" in the git log because I am following the issue with no real knowledge of the topic myself. |
Kixunil
approved these changes
Jan 22, 2023
apoelstra
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From BIP143:
Currently we are using a
Sighashwhich wraps double sha256 so while technically correct this means we are relying onSighashto implementEncodable. We can remove this requirement by directly using thesha256d::Hashtype to hash the outputs data.Fix: #1549