-
Notifications
You must be signed in to change notification settings - Fork 831
Move base58
to the crate root
#1417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This one, like #1400, should eventually go in |
@Kixunil let's move discussion of How do you feel about creating a module called |
For
|
Ok, if we want |
9f84af7
to
c12a17b
Compare
Rebase only, no other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c12a17b6a754536569efcb3d090a072a14b52a01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c12a17b6a754536569efcb3d090a072a14b52a01
Needs rebase. (Tried localy, it's a real merge failure). Caused by #1373 |
In preparation for removing the `util` module move the `base58` module to the crate root. This is likely not the final resting place for this module but it is a step in the right direction. Includes addition of rustfmt attribute to skip formatting the digits array. No other changes to the `base58` module.
Run `cargo +nightly fmt` and commit the changes to the `base58` module. No manual changes, only those done by the formatter.
c12a17b
to
4c8570b
Compare
Rebase only, no other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 4c8570b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 4c8570b
Merging this as it marked as high prio |
Move
base58
module to the carte root, directrustfmt
to not format the digits array. Run formatter as a separate patch.