8000 Make Instruction Copy by casey · Pull Request #1376 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make Instruction Copy #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2022
Merged

Make Instruction Copy #1376

merged 1 commit into from
Nov 12, 2022

Conversation

casey
Copy link
Contributor
@casey casey commented Nov 8, 2022

Closes #1368.

@casey casey mentioned this pull request Nov 8, 2022
Closed
Kixunil
Kixunil approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 80f6a4c

I don't expect Instruction to ever become non-Copy.

@Kixunil Kixunil added enhancement minor API Change This PR should get a minor version bump trivial Obvious, easy and quick to review (few lines or doc-only...) one ack PRs that have one ACK, so one more can progress them labels Nov 8, 2022
tcharding
tcharding approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 80f6a4c

apoelstra
apoelstra approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 80f6a4c

@apoelstra apoelstra merged commit 5d23e8c into rust-bitcoin:master Nov 12, 2022
@casey casey deleted the instruction-derive-copy branch November 12, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
enhancement minor API Change This PR should get a minor version bump one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should Instruction implement Copy?
4 participants
@casey @Kixunil @apoelstra @tcharding
0