8000 ci: Remove serde version pinning by tcharding · Pull Request #1341 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: Remove serde version pinning #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

tcharding
Copy link
Member

The MSRV break in serde is fixed now, remove the serde version pinning.

Fix: #1256

The MSRV break in serde is fixed now, remove the serde version pinning.
@tcharding
Copy link
Member Author

I did not research this, just running it through CI to see if unpinning passes 1.41.1 job.

@Kixunil
Copy link
Collaborator
Kixunil commented Oct 24, 2022

Oh, I thought I removed this when committing Cargo.lock...

Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b05ba16 if CI passes.

@Kixunil Kixunil added ci Tests trivial Obvious, easy and quick to review (few lines or doc-only...) labels Oct 24, 2022
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b05ba16

@apoelstra apoelstra merged commit f9146d0 into rust-bitcoin:master Oct 25, 2022
@tcharding tcharding deleted the 10-25-remove-serde-pinning branch October 25, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Tests trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We can probably unpin serde now
3 participants
0