Improve doc of Script::push_verify
#1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! This is much clearer. |
apoelstra
previously approved these changes
Oct 21, 2022
tcharding
reviewed
Oct 21, 2022
bitcoin/src/blockdata/script.rs
Outdated
| /// Adds an `OP_VERIFY` to the script, unless the most-recently-added | ||
| /// opcode has an alternate `VERIFY` form, in which case that opcode | ||
| /// is replaced e.g., `OP_CHECKSIG` will become `OP_CHECKSIGVERIFY`. | ||
| /// Adds an `OP_VERIFY` to the script or replaces the last opcode with VERIFY form |
There was a problem hiding this comment.
For my learning; is there a reason you do not put a full stop on the brief description?
There was a problem hiding this comment.
I guess a bad habit from git.
Kixunil
commented
Oct 21, 2022
This rewords the doc to have a reasonable summary, adds a little background explaining the opcode behavior and the effect of the function when called multiple times. Closes ##1154
69d83d6 to
7e39082
Compare
tcharding
approved these changes
Oct 21, 2022
apoelstra
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewords the doc to have a reasonable summary, adds a little background explaining the opcode behavior and the effect of the function when called multiple times.
Closes #1154