8000 Fix `test_data` dir exclusion by RCasatta · Pull Request #1315 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix test_data dir exclusion #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

Fix test_data dir exclusion #1315

merged 1 commit into from
Oct 13, 2022

Conversation

RCasatta
Copy link
Collaborator

I noted our released crate 0.29.1 was bigger than expected and noted with cargo package --list that even with our exclude the test_data dir was included. I am also going to backport this.

As specified in the doc:

foo/ matches any directory with the name foo anywhere in the package.

@RCasatta
fix test_data dir exclusion
13e9a13 
As specified in the doc:

`foo/` matches any directory with the name `foo` anywhere in the package.
@RCasatta RCasatta changed the title fix test_data dir exclusion Fix test_data dir exclusion Oct 11, 2022
@RCasatta RCasatta mentioned this pull request Oct 11, 2022
Merged
apoelstra
apoelstra approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 13e9a13

@RCasatta RCasatta added one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...) labels Oct 12, 2022
sanket1729
sanket1729 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member
@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 13e9a13

@RCasatta RCasatta merged commit abc1d47 into rust-bitcoin:master Oct 13, 2022
apoelstra added a commit that referenced this pull request Oct 26, 2022
@apoelstra
Merge #1316: bump version to 0.29.2, fix test_data exclude
fa8ff23 
db8ff70 bump version to 0.29.2, fix test_data exclude (Riccardo Casatta)
6a9b55c fuzz: use travis-fuzz.sh in CI (Andrew Poelstra)
b4f750c fuzz: remove mysteriously-not-necessary quotes from gh action script (Andrew Poelstra)
a6f6ead fuzz: disable features in honggfuzz (Andrew Poelstra)
f857fe1 Fix clippy warnings (Tobin C. Harding)

Pull request description:

  backport of #1315

  reduce crate package from 1.7M to 500k

ACKs for top commit:
  tcharding:
    ACK db8ff70
  apoelstra:
    ACK db8ff70

Tree-SHA512: 51af259df5bf115866deefcedcab706c6f5b316695fb2cdc958f6265b7ea371db84354441565c1c125907de6c1fe0c73ac31c9cdaf1c34ed4733471b4075b5b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees
No one assigned
Labels
one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RCasatta @apoelstra @sanket1729
0