Move bip158 module to crate root #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new match-arm formatting looks kinda bad to me but I won't die on this hill. |
apoelstra
previously approved these changes
Aug 24, 2022
|
Now you mention it, I tend to agree. So as not to open up a can of worms right now perhaps we can leave it like this and come back to it at a later time? |
|
If you mean, leaving this file blacklisted by |
|
I'll leave the new formatting, I'm pretty sure this was one of the config changes introduced during the "less vertical lines is better" debate. |
We are attempting to flatten the `util` module; move the `bip158` module to the crate root out of `util`. Currently `src/util/` is ignored by the formatter so this move causes the `bip32` module to be formatted.
Run the formmater on the newly moved `bip158` module. No changes other than those introduced by `cargo +nightly fmt`.
bcc7afc to
01161e6
Compare
|
Rebase to pick up recent fuzzer change. |
apoelstra
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are attempting to flatten the
utilmodule.Move the
bip158module to the crate root out ofutil.Currently
src/util/is ignored by the formatter so this move requiresbip158module to be formatted. Formatting is done as a separate patch so reviewers can runcargo +nightly fmtand compare the diffs if so desired.