Remove old deprecated code #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a9f81b to
5f3c8ff
Compare
|
Draft while I actually do it properly. |
In preparation for adding unit tests to the `sighash` module clean up the import statements. Refactor only, no logic changes.
We have a bunch of unit tests that verify the BIP 143 test vectors. Three of these use the deprecated `SighashComponents` struct. We should implement these tests using the new `SighashCache`. In order to do so we have to move the tests to the `sighash` module so they can get access to the private `segwit_cache()` function, and verify the cache internal state against the test vectors. Re-write the BIP 143 test vector code using `SighashCache` and remove the versions using `SighashComponents`. Done in preparation for removing the deprecated `SighashComponents`.
The `bip143::SigHashCache` is deprecated in favour of `sighash::SighashCache` however we still use it in `bip143` unit tests. Use the new `sighash::SighashCache` in `bip143` unit tests.
This struct was deprecated in v0.24.0, we can safely remove it now.
We have two methods that have been deprecated since 0.26.2, we can safely remove them now.
5f3c8ff to
dfb8ef9
Compare
AFAIK there's none but anything is good enough IMO. We do unannounced changes too. 🤷♂️ . |
|
I'll ACK this but in the interest of getting the release out I think we'll wait til after 0.29.0 to merge |
apoelstra
approved these changes
Aug 3, 2022
|
Oh yes, I expected that. I'll add 0.30 milestone and try to remember to add labels/milestones to my PRs. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the exact policy we decided on for deprecating is but we have code deprecated since v0.24.0 and v.026.2, both of these seem reasonable safe to remove.
Removal of
SighashCompontentsuncovered the fact that we never moved the BIP 143 test vector code over to the newSighashCache.sighash::SighashCacheSighashCacheinstead ofSigHashCacheSighashComponentsstruct deprecated in 0.24.0MerkleBlockmethods deprecated in 0.26.2