Remove stale MSRV docs #1126
Merged
Remove stale MSRV docs #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have stale docs referring to the old MSRV. We do not need MSRV docs in `CONTRIBUTING` because we have them in the README already. Fix stale docs by doing: - Remove the MSRV docs from readme in favour of `CONTRIBUTING.md`. - Add a sentence to the redame pointing readers towards `CONTRIBUTING.md`.
We have docs that use an env var `BITCOIN_MSRV` that no longer exists. Point readers towards `RUSTUP_TOOLCHAIN`. (Note that we still use `TOOLCHAIN` in the script but it is being phased out, `RUSTUP_TOOLCHAIN` works today.)
apoelstra
approved these changes
Jul 26, 2022
Kixunil
approved these changes
Jul 26, 2022
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
fe840f0 Fix stale toolchain docs (Tobin C. Harding) 73b506e Remove stale MSRV docs (Tobin C. Harding) Pull request description: We have stale docs referring to the old MSRV. We do not need MSRV docs in `CONTRIBUTING` because we have them in the README already. Fix stale docs by doing: - Remove the MSRV docs from readme in favour of `CONTRIBUTING.md`. - Add a sentence to the redame pointing readers towards `CONTRIBUTING.md`. - Point readers towards `RUSTUP_TOOLCHAIN` ACKs for top commit: apoelstra: ACK fe840f0 Kixunil: ACK fe840f0 Tree-SHA512: 6d3006db7a460e5d7146b73ff4b99dc322d396e65da39f5ea47c4904aa387c8a36e4a8ae707653dbab90096e692bf69918e6c19c4d3d989c85b22dba4dcba904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have stale docs referring to the old MSRV. We do not need MSRV docs
in
CONTRIBUTINGbecause we have them in the README already.Fix stale docs by doing:
CONTRIBUTING.md.CONTRIBUTING.md.RUSTUP_TOOLCHAIN