8000 refactor: remove SchnorrSignatureHash::Reserved variant by Eunoia1729 · Pull Request #1031 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove SchnorrSignatureHash::Reserved variant #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2022
Merged

refactor: remove SchnorrSignatureHash::Reserved variant #1031

merged 1 commit into from
Jun 1, 2022

Conversation

Eunoia1729
Copy link
Contributor

Resolves #1030

sanket1729
sanket1729 approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member
@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 69707b0. For reference to other reviewers:

From BIP 341:

The following restrictions apply, which cause validation failure if violated: Using any undefined hash_type (not 0x00, 0x01, 0x02, 0x03, 0x81, 0x82, or 0x83[13]).

tcharding
tcharding approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 69707b0

@tcharding
Copy link
Member

Thanks @Eunoia1729!

apoelstra
apoelstra approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 69707b0

@apoelstra apoelstra merged commit 09b4198 into rust-bitcoin:master Jun 1, 2022
@Eunoia1729 Eunoia1729 deleted the remove-reserved-sighash-variant branch June 2, 2022 15:53
ChallengeDev210 pushed a commit to ChallengeDev210/rust-bitcoin that referenced this pull request Aug 1, 2022
@apoelstra
Merge rust-bitcoin/rust-bitcoin#1031: refactor: remove SchnorrSignatu…
ce2d745 
…reHash::Reserved variant

69707b0 refactor: remove SchnorrSignatureHash::Reserved variant (eunoia_1729)

Pull request description:

  Resolves #1030

ACKs for top commit:
  sanket1729:
    utACK 69707b0. For reference to other reviewers:
  tcharding:
    ACK 69707b0
  apoelstra:
    ACK 69707b0

Tree-SHA512: d5afe9217e15db8dfd7d712e2fa69d22acda0f93fd7efbc80cf9459303a135a69c8ddf43842584769accb8cffba722ec202dc51f100e0f50262b2561a2fb1699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the Sighash::Reserved variant
4 participants
@Eunoia1729 @tcharding @apoelstra @sanket1729
0