[backport] Fix no_std MSRV
#986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
approved these changes
May 3, 2022
| @@ -1,5 +1,6 @@ | |||
| target | |||
| Cargo.lock | |||
| dep_test | |||
There was a problem hiding this comment.
I mean no reason to add this without adding the test crate, but of course also doesn't hurt anything, so....
There was a problem hiding this comment.
I don't get why you mention the test crate. This directory is created in the test.sh script. This chage, AFAICT, helps devs running the test script with AS_DEPENDENCY set to true.
|
Oops, it looks like #985 beat me to the punch ... @tcharding should we close this one or yours? I believe they are identical except for the name of the branch that we're merging into. Why is yours marked DO NOT MERGE? |
I wrote that when the target branch was |
tcharding
approved these changes
May 4, 2022
mcroad
approved these changes
May 4, 2022
|
Merged, tagged and published. |
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
e45f6c7 bump version to 0.28.1 (Andrew Poelstra) eaaa3d0 [backport] Fix `no_std` MSRV (mcroad) Pull request description: Backport of #690 to 0.28 ACKs for top commit: tcharding: ACK e45f6c7 Tree-SHA512: 5e1459b83044acb2a628e612a45f5be5b05067429fcc7b4c4c46713bd61ee43032bbe52a80a2fc9a3ebe7cb649c2554c6500e7f7d6ea3da35e97150ca6431fc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #690 to 0.28