8000 util::amount: Make from_sat constructor constant by stevenroose · Pull Request #902 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

util::amount: Make from_sat constructor constant #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2022
Merged

util::amount: Make from_sat constructor constant #902

merged 1 commit into from
Apr 22, 2022

Conversation

stevenroose
Copy link
Collaborator

Currently unmergable because of MSRV but I heard talk about bumping it, so once it's bumped, this is a very much needed change :)

@tcharding tcharding added this to the 0.29.0 milestone Mar 23, 2022
@tcharding
Copy link
Member

Should we consider making all the basic conversion methods const (i.e., across the whole crate/stack)?

tcharding
tcharding approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 31571ca

@apoelstra
Copy link
Member

Why are there now no CI checks?

@apoelstra
Copy link
Member

Merged #964 .. hopefully that wakes up github and it reinstates all the actions?

apoelstra
apoelstra approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 31571ca

I ran my local CI script and this seems pretty clearly unlikely to cause any breakage ... let's just merge it?

@tcharding
Copy link
Member

lol, GitHub. Yeah let's merge, yolo!

@apoelstra apoelstra merged commit 83514c8 into rust-bitcoin:master Apr 22, 2022
ChallengeDev210 pushed a commit to ChallengeDev210/rust-bitcoin that referenced this pull request Aug 1, 2022
@apoelstra
Merge rust-bitcoin/rust-bitcoin#902: util::amount: Make from_sat cons…
d9f844b 
…tructor constant

31571ca util::amount: Make from_sat constructor constant (Steven Roose)

Pull request description:

  Currently unmergable because of MSRV but I heard talk about bumping it, so once it's bumped, this is a very much needed change :)

ACKs for top commit:
  tcharding:
    ACK 31571ca
  apoelstra:
    ACK 31571ca

Tree-SHA512: f254eb10a4349d890e29ea5fae77536429c7e731362cf2edcf2fe98ec9cbf2d8bbf65f98dfc8f0b80bac89960de688005d066a116d6cb62cca1efa9c1151f2ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenroose @tcharding @apoelstra
0