Add a method to psbt to compute find sighash type #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a07b3d to
74f3e57
Compare
sanket1729
reviewed
Feb 25, 2022
src/util/psbt/map/input.rs
Outdated
| @@ -191,6 +191,22 @@ impl PsbtSigHashType { | |||
| } | |||
|
|
|||
| impl Input { | |||
| /// Returns sighash_type.ecdsa_hash_ty() is sighash_type exists else | |||
There was a problem hiding this comment.
The documentation can updated as
/// Obtains the [EcdsaSigHashType] for this input if one is specified. If no sighash type is specified, returns ...
///
/// Errors:
/// If the sighash type is not a standard ecdsa sighash type
Same comment for schnorr
|
You can cherry-pick #848 to get the CI working |
74f3e57 to
fee6ab6
Compare
Fixes rust-bitcoin#838: Add a utility method to psbt to compute find sighash type of a given input.
fee6ab6 to
4b1db0a
Compare
|
Hi @sanket1729, thanks for the fix! I cherry-picked the commit and fixed the documentation issue. |
|
You can remove the cherry-pick now :) |
|
ACK 4b1db0a934a8f795903fde9119aebf06c4aa740e but would prefer to see the cherry-pick removed. |
4b1db0a to
fb04cab
Compare
removed the cherry-pick commit :) |
apoelstra
approved these changes
Feb 26, 2022
Kixunil
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838: Add a utility method to psbt to compute find sighash
type of a given input.
For now, I have changed my previous implementation as discussed in #838 to functional style code as suggested by @Kixunil.