Added generation of data method in impl_array_newtype macro
#81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agree, it is useful. Recently I had to convert Sha256dHash to Uint256 just to be able to get the lower half of hash to seed sip hash key (BIP158). @apoelstra merge? |
|
Are the slicing methods insufficient for this? |
|
In some cases such a method looks better in code than slicing. |
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
Fixes rust-bitcoin#81 completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is very useful to be able to get contents from an array-based type.
Use case: when use
Sha256dHashand you need to convert it to some Hash implementation in another library. In most cases Hash type may be constructed from[u8; 32]and thus such a method will make process simpler.