8000 Issue #394 - Refactor Block::merkle_root() by nilswloewen · Pull Request #775 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Issue #394 - Refactor Block::merkle_root() #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2022
Merged

Issue #394 - Refactor Block::merkle_root() #775

merged 2 commits into from
Jan 13, 2022

Conversation

nilswloewen
Copy link
Contributor

Refactor Block::merkle_root() to Block::compute_merkle_root() and deprecate Block::merkle_root().

@nilswloewen
Issue #394 - Refactor Block::merkle_root() to
0578828 
Block::compute_merkle_root() and deprecate Block::merkle_root().
@nilswloewen nilswloewen mentioned this pull request Jan 12, 2022
Closed
@tcharding
Copy link
Member

Ha! The title of this PR threw me, I thought it was an issue not a PR :)

@apoelstra
Copy link
Member

This looks fine to me because it's just a 2-line function, but it might be clearer if the deprecated function just called the non-deprecated one rather than duplicating the logic.

concept ACK changing the name.

tcharding
tcharding reviewed Jan 12, 2022
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the deprecated version changed, LGTM!
8000

@nilswloewen
Copy link
Contributor Author

Thanks for the feedback @apoelstra and @tcharding. I've made the changes you've suggested.

@tcharding
Copy link
Member

Thanks, LGTM.

@Kixunil
Copy link
Collaborator
Kixunil commented Jan 13, 2022

I think squashing would be useful.

apoelstra
apoelstra approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cd2435c

Thanks for your contribution!

Agreed about squashing, but for such a small diff I'm not going to hold things up.

Kixunil
Kixunil approved these changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cd2435c

@apoelstra apoelstra merged commit 907b3a7 into rust-bitcoin:master Jan 13, 2022
@dr-orlovsky dr-orlovsky mentioned this pull request Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcharding tcharding tcharding left review comments

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nilswloewen @tcharding @apoelstra @Kixunil
0