add fuzzer output to gitignore; remove ancient secp build instructions from Travis #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Apr 3, 2018
.gitignore
Outdated
| @@ -1,6 +1,10 @@ | |||
| target | |||
| Cargo.lock | |||
|
|
|||
| #fuzzer output | |||
| fuzz/hfuzz_target | |||
| fuzz/hfuzz_workspace | |||
There was a problem hiding this comment.
I think we'd need to move the committed-input-vectors to another directory and have travis-fuzz.sh copy them over.
There was a problem hiding this comment.
For what it's worth, it's possible to have committed files in a .gitignore location, and even to update them, it's just mysterious and a pain in the ass. Agreed we should not do this :)
I'll update the PR to copy stuff.
dc6d21e to
607016d
Compare
Tibo-lg
pushed a commit
to p2pderivatives/rust-bitcoin
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling libsecp in Travis was needed in 2014 when rust-secp did not bundle its own copy of libsecp.