8000 Tapsighash test vectors by sanket1729 · Pull Request #705 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tapsighash test vectors #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2022
Merged

Tapsighash test vectors #705

merged 1 commit into from
Jan 3, 2022

Conversation

sanket1729
Copy link
Member

Based on #695 . Adds the remaining test vectors to test sighash paths. Will rebase after #695

@sanket1729 sanket1729 force-pushed the tapsighash_test_vectors branch from 003848f to e0772d6 Compare November 22, 2021 17:36
@dr-orlovsky
Copy link
Collaborator

Needs rebase

@Kixunil Kixunil added the waiting for author This can only progress if the author responds to a request. label Dec 2, 2021
@sanket1729 sanket1729 force-pushed the tapsighash_test_vectors branch from e0772d6 to 31100a3 Compare December 12, 2021 16:26
@sanket1729 sanket1729 removed the waiting for author This can only progress if the author responds to a request. label Dec 15, 2021
@sanket1729 sanket1729 force-pushed the tapsighash_test_vectors branch 2 times, most recently from 9c7cbb2 to 6648477 Compare December 23, 2021 18:50
apoelstra
apoelstra previously approved these changes Dec 24, 2021
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6648477ff2471a79451952aa4f32cb9cd2a4fe58

@RCasatta
Copy link
Collaborator

Needs rebase

@sanket1729 sanket1729 force-pushed the tapsighash_test_vectors branch from 6648477 to 92ee5a7 Compare December 31, 2021 22:42
@sanket1729
Copy link
Member Author

Rebased

apoelstra
apoelstra approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 92ee5a7

RCasatta
RCasatta approved these changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator
@RCasatta RCasatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 92ee5a7

Maybe one day we can have an internal-only crate test-utilities used as a dev-dependency where we can put things like fn bip_341_read_json

@RCasatta RCasatta merged commit 4fa477c into rust-bitcoin:master Jan 3, 2022
@dr-orlovsky dr-orlovsky mentioned this pull request Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@RCasatta RCasatta RCasatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sanket1729 @dr-orlovsky @RCasatta @apoelstra @Kixunil
0