Return the correct LeafVersion when building a Taproot ControlBlock
#703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
approved these changes
Nov 16, 2021
sanket1729
reviewed
Nov 16, 2021
sanket1729
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
This is also done in #695. I can drop the commit entirely there
|
I like having smaller commits but merging it myself would feel like imposing it on others. :) |
|
Done. @Kixunil if you can I also recommend using it whenever you merge a commit, it allows you to sign off commits with your key. |
|
Thanks for info! I will have to look into proper GPG commits setup with git and Qubes. Was only doing tags so far by manually copying repo to a different VM. :D |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull reque
2AE5
st is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.