Fixed a bunch of clippy lints, added clippy.toml #686
Conversation
e70297b to
fea88ae
Compare
Of possible relevance to this work is: #688 (further configures clippy). |
| /// Error returned when parsing `SigHashType` fails. | ||
| /// | ||
| /// This is currently returned for unrecognized sighash strings. | ||
| #[derive(Debug, Clone)] |
There was a problem hiding this comment.
#[derive(ParialEq, Eq, PartialOrd, Ord)], according to our new contributing guidelines :)
There was a problem hiding this comment.
TBH, I'm not really convinced errors should commit to Ord/PartialOrd. Maybe Eq is fine.
There was a problem hiding this comment.
If there's Eq there should be Hash, I believe.
In this specific case I'm not even sure about Eq. Are two errors carrying information saying "can't recognize sighash string" (by their existence) that were caused by different input (which they write for ease of debugging) equal or not?
| /// Error returned when a command string is invalid. | ||
| /// | ||
| /// This is currently returned for command strings longer than 12. | ||
| #[derive(Clone, Debug)] |
There was a problem hiding this comment.
Here I still think #[derive(PartialEq, Eq)] will be nice to have
|
@Kixunil needs rebase :( |
693f666
|
Rebased |
| /// Error returned when a command string is invalid. | ||
| /// | ||
| /// This is currently returned for command strings longer than 12. | ||
| #[derive(Clone, Debug)] |
There was a problem hiding this comment.
Here I still think #[derive(PartialEq, Eq)] will be nice to have
|
Will wait a bit if others have an opinion on this. Basically the question is "Do we want to commit to always carry error information that can be meaningfully compared?" |
|
If I remember correctly @apoelstra doesn't like struct initialization shorthand |
|
Shame, I do like it but willing to |
|
Adding allows everywhere will be messy as hell, structs get initialized all over the place. Probably best to let @apoelstra comment before starting a fight in his name though :) |
|
@tcharding I think they could be allowed globally in |
|
yeah, I realised this last night when I was going to sleep :) |
|
Sorry for being absent. I don't like the compact struct initialization format but I won't hold things up about it. I'm used to it by now :). Regarding errors satisfying Needs rebase. |
This is the initial step towards using and maybe enforcing clippy. It does not fix all lints as some are not applicable. They may be explicitly ignored later.
|
Rebased |
This is the initial step towards using and maybe enforcing clippy.
It does not fix all lints as some are not applicable. They may be
explicitly ignored later.
Some discussion about clippy was in #685