8000 Add i686 to tested architectures by Kixunil · Pull Request #659 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add i686 to tested architectures #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2021
Merged

Add i686 to tested architectures #659

merged 1 commit into from
Sep 20, 2021

Conversation

Kixunil
Copy link
Collaborator
@Kixunil Kixunil commented Sep 19, 2021

This adds i686 to CI which can help catching pointer-size-related bugs
such as the one addressed by #658.

Opening a new PR seemed more appropriate than adding it to #658 I can change it if you disagree.

@Kixunil Kixunil force-pushed the ci-test-i686 branch 2 times, most recently from be11ce5 to bbefe33 Compare September 19, 2021 14:11
@Kixunil
Copy link
Collaborator Author
Kixunil commented Sep 19, 2021

Anyone has an idea why apt can't install it on Ubuntu? It works fine in Debian 10.

@Kixunil
Add i686 to tested architectures
f2042bd 
This adds i686 to CI which can help catching pointer-size-related bugs
such as the one addressed by rust-bitcoin#658.
@TheBlueMatt
Copy link
Member

We should probably figure out how to run fuzzing on 32-bit architectures, too.

@RCasatta
Copy link
Collaborator

Another option for the CI to test i686 and many other arch is leveraging the cross test.
At the moment we use it only for big-endian architecture in

rust-bitcoin/.github/workflows/rust.yml

Lines 46 to 63 in b7f9849

Cross:
name: Cross testing
runs-on: ubuntu-latest
steps:
- name: Checkout Crate
uses: actions/checkout@v2
- name: Checkout Toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
override: true
- name: Install target
run: rustup target add s390x-unknown-linux-gnu
- name: install cross
run: cargo install cross
- name: run cross test
run: cross test --target s390x-unknown-linux-gnu
but we could easily extend with matrix strategy like here rust-bitcoin/rust-secp256k1#317

@Kixunil
Copy link
Collaborator Author
Kixunil commented Sep 20, 2021

As I understand it that one uses emulation and i686 can be run directly on x86_64, which should be faster so that's why opted for it.

apoelstra
apoelstra approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

ACK f2042bd

@apoelstra apoelstra merged commit 4bd3e1d into rust-bitcoin:master Sep 20, 2021
@Kixunil Kixunil deleted the ci-test-i686 branch September 20, 2021 15:10
@dr-orlovsky dr-orlovsky added this to the 0.28.0 milestone Sep 25, 2021
@dr-orlovsky dr-orlovsky mentioned this pull request Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kixunil @TheBlueMatt @RCasatta @apoelstra @dr-orlovsky
0