8000 Optional feature gives access to Bitcoin Core's own script validator by tamasblummer · Pull Request #58 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Optional feature gives access to Bitcoin Core's own script validator #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2018
Merged

Optional feature gives access to Bitcoin Core's own script validator #58

merged 1 commit into from
Mar 12, 2018

Conversation

tamasblummer
Copy link
Contributor

Adds a feature "bitcoinconsensus" which if enabled links this library with rust-bitcoinconsensus project.
That project wraps Bitcoin Core's own script interpreter for Rust. Use Transaction::verify and Script::verify methods to validate using Bitcoin Core's code.

@tamasblummer
Copy link
Contributor Author

@apoelstra please review

@apoelstra
Copy link
Member

Can you rebase this and update the README commit to add

  • Removed old script interpreter and moved in-memory blockchain to rust-bitcoin-chain
  • Replaced Base58 traits with encode_slice, check_encode_slice, from and from_check functions in the base58 module

Because these are also big breaking changes that will go into 0.12.

We may also bring in bech32 support but I'll add that in a separate update to the README.

@tamasblummer
Copy link
Contributor Author

This is already rebased to current master

@apoelstra
Copy link
Member
apoelstra commented Mar 12, 2018 •
edited
Loading

Can you rebase this to remove the merge commit and remove the patch.crates-io thing in Cargo.toml in the first couple commits?

Also to combine the three README-related commits?

@tamasblummer
Copy link
Contributor Author

@apoelstra would a squash merge not do the same thing?

@apoelstra
Copy link
Member

@tamasblummer There is a merge commit in the PR; a squash merge would prevent an additional merge commit from appearing, but that one is not the one I'm concerned about.

@tamasblummer tamasblummer force-pushed the libbitcoinconsenus_feature branch from ae60fea to 755fb45 Compare March 12, 2018 16:21
@tamasblummer
Copy link
Contributor Author

@apoelstra rebased and squashed

apoelstra
apoelstra approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, ok, that works I guess.

@apoelstra apoelstra merged commit c8702ab into rust-bitcoin:master Mar 12, 2018
@tamasblummer tamasblummer deleted the libbitcoinconsenus_feature branch March 12, 2018 20:18
@apoelstra apoelstra mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamasblummer @apoelstra
0