8000 Fixing serde impl for PSBT inputs by dr-orlovsky · Pull Request #512 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing serde impl for PSBT inputs #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2020
Merged

Fixing serde impl for PSBT inputs #512

merged 1 commit into from
Nov 7, 2020

Conversation

dr-orlovsky
Copy link
Collaborator

No description provided.

apoelstra
apoelstra approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! utack, pending CI

@apoelstra
Copy link
Member

Looks like this was caused because #508 and #478 were merged at the same time

This was referenced Nov 6, 2020
Merged
Merged
@stevenroose stevenroose merged commit 3f465d5 into rust-bitcoin:master Nov 7, 2020
@stevenroose
Copy link
Collaborator

#508 wasn't merged, though. I don't think this obsoletes #508 either, right? But I should probably rebase that?

@apoelstra
Copy link
Member

Yeah, I think I meant #507 and #478, which were merged at the same time, though it's not obvious to me looking back where the conflict was.

Agreed, rebasing #508 would be great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenroose stevenroose stevenroose approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dr-orlovsky @apoelstra @stevenroose
0