bump version to 0.25.1 #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to add #480 to changelog |
4 tasks
abcd0ac to
17e733d
Compare
dr-orlovsky
suggested changes
Oct 9, 2020
There was a problem hiding this comment.
NACK: 3618d7a was a breaking change, so it can't be 0.25.1 anymore. See rust-bitcoin/rust-miniscript#153
Hmm that method returns a |
|
Here: #493 |
|
Ok #493 is merged |
|
Is it possible to release this version on Monday pls? Any more reviewers, @stevenroose, @elichai? |
|
@dr-orlovsky I would like to get #413 in first. |
|
Should maybe add #500 to changelog |
|
Should add #413 to changelog |
dr-orlovsky
reviewed
Oct 16, 2020
8000
Co-authored-by: Dr. Maxim Orlovsky <orlovsky@pandoracore.com>
dr-orlovsky
approved these changes
Oct 16, 2020
TheBlueMatt
approved these changes
Oct 19, 2020
stevenroose
approved these changes
Oct 20, 2020
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
…e additional methods for converting to a DescriptorPublicKey 1477dbb DefiniteDescriptorKey: provide additional methods for converting to a DescriptorPublicKey (Andrew Poelstra) Pull request description: Fixes rust-bitcoin#491 I didn't provide a mutable version of this. I'm not sure if we want to support this or not; generally public keys should be immutable after creation. ACKs for top commit: sanket1729: ACK 1477dbb Tree-SHA512: 8c06ac3b6c395c3805b8cbd958ce4f354025ee88b2915562662cb084216048c6543591c468112981e8afa72d89373a544965096227475f0c198af9194d826a7e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.