Add Block::get_size() and Block::get_weight() #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
==========================================
+ Coverage 85.81% 86.07% +0.25%
==========================================
Files 40 40
Lines 7461 7698 +237
==========================================
+ Hits 6403 6626 +223
- Misses 1058 1072 +14
Continue to review full report at Codecov.
|
shesek
added a commit
to Blockstream/electrs
that referenced
this pull request
Mar 24, 2020
- Fixes a bug in block weight calculation, which didn't take the size of the block header and tx count varint into account. - Avoids re-serializing blocks in order to determine their size during the indexing process. - Avoids re-serializing transactions in order to include their size in API responses. This depends on two unmerged PRs that are implemented in blockstream/rust-bitcoin#0.23-electrs: rust-bitcoin/rust-bitcoin#416 rust-bitcoin/rust-bitcoin#417
|
Can you rebase? Seems that there are still two commits in this PR even after #416 is merged |
83982da to
94032f6
Compare
|
@apoelstra rebased |
stevenroose
approved these changes
Mar 31, 2020
apoelstra
approved these changes
Apr 7, 2020
SatoKentaNayoro
pushed a commit
to boolnetwork/mempool-electrs
that referenced
this pull request
Nov 29, 2024
- Fixes a bug in block weight calculation, which didn't take the size of the block header and tx count varint into account. - Avoids re-serializing blocks in order to determine their size during the indexing process. - Avoids re-serializing transactions in order to include their size in API responses. This depends on two unmerged PRs that are implemented in blockstream/rust-bitcoin#0.23-electrs: rust-bitcoin/rust-bitcoin#416 rust-bitcoin/rust-bitcoin#417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're a bit tricky to get right (I was missing the size of the tx count varint when I initially implemented this in another project), so could be useful to have this as part of rust-bitcoin.
Depends on #416.