Expand decoder tests and improve handling of variable-sized uints #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- test: increase decoding coverage for all types
- fix: correct handling of large uints
This should cover all the major edge cases when decoding the data section.
Previously, we were not correctly handling variable-sized uints.
5b32d92 to
293091e
Compare
|
Looking good, left a comment which is more of a nit - feel free to ignore it if you like |
runk
approved these changes
Apr 30, 2025
| @@ -277,7 +277,7 @@ export default class Decoder { | |||
| return this.db.readUIntBE(offset, size); | |||
| } | |||
| if (size == 8) { | |||
| return this.db.readBigInt64BE(offset).toString(); | |||
| return this.db.readBigUInt64BE(offset).toString(); | |||
src/decoder.test.ts
Outdated
| ]; | ||
|
|
||
| for (const tc of testCases) { | ||
| const inputStr = |
There was a problem hiding this comment.
This is used a bunch of times - maybe a worthwhile making a small helper fn for it. Same for expectedStr.
There was a problem hiding this comment.
Thanks. I did that for the three inputStr uses. For expectedStr, the two uses are different as one is for a string and the other is for a Buffer.
runk
approved these changes
May 1, 2025
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.