Extract Rails classes into their respective files #50

joostvanrijn · 2025-04-01T20:18:13Z

This might result in:

      NoMethodError - undefined method `**' for nil:

      def submit(value = submit_value, **attributes)
        input ** attributes.merge(
          name: "commit",
          type: "submit",
          value: value
        )
      end

I will look into this

mvkampen · 2025-04-10T09:55:57Z

lib/superform/rails/form.rb

+      # ```
+      #
+      # Now all calls to `label` will have the `text-bold` class applied to it.
+      class Field < Superform::Field


I think it would be nicer to have this in a seperate file
This should be possible with zeitwerk?

'lib/superform/rails/form/field.rb'

I tried that, but Superform::Rails::Form is already defined as a class (in this very file), so it results in a name conflict. It would take some renaming to fix that. (I'm open to suggestions).

mvkampen · 2025-04-10T10:11:54Z

This might result in:

      NoMethodError - undefined method `**' for nil:

      def submit(value = submit_value, **attributes)
        input ** attributes.merge(
          name: "commit",
          type: "submit",
          value: value
        )
      end

I will look into this

attributes cant be passes as nil, if you pass nil it will raise ArgumentError:
wrong number of arguments (given 2, expected 0..1) (ArgumentError)

Other suggestion:
input(name: 'commit', type: 'submit', value: value, **attributes)

But the behavior changes as you will get a SyntaxError, if you will provide the key type:, name:, or :value in attributes, as you send duplicate keywords to input.

joostvanrijn · 2025-04-23T18:14:15Z

This might result in:

      NoMethodError - undefined method `**' for nil:

      def submit(value = submit_value, **attributes)
        input ** attributes.merge(
          name: "commit",
          type: "submit",
          value: value
        )
      end

I will look into this

There seems to be some sort of syntax error here. If I rewrite it like the following, it works just fine:

      def submit(value = submit_value, **attributes)
        input(**attributes.merge(
          name: "commit",
          type: "submit",
          value: value
        ))
      end

Extract Rails classes into their respective files

ba1478a

mvkampen suggested changes Apr 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Extract Rails classes into their respective files #50

Extract Rails classes into their respective files #50

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Extract Rails classes into their respective files #50

Are you sure you want to change the base?

Extract Rails classes into their respective files #50

Uh oh!

Conversation

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!