8000 Pry-like syntax highlight for IRB by k0kubun · Pull Request #2150 · ruby/ruby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pry-like syntax highlight for IRB #2150

Closed
wants to merge 4 commits into from
Closed

Pry-like syntax highlight for IRB #2150

wants to merge 4 commits into from

Conversation

k0kubun
Copy link
Member
@k0kubun k0kubun commented Apr 25, 2019

When both $stdout.tty? and ENV.key?('TERM') are true, IRB in this PR performs pry-like syntax highlight for the following places:

  • On binding.irb
  • On inspect output of core class objects like Integer, String, Symbol, Array, Hash.

This PR does NOT colorize the input code yet because it may conflict with #2144.

Demo

Screen Shot 2019-04-25 at 22 08 37

@k0kubun k0kubun force-pushed the irb-syntax-highlight branch 2 times, most recently from a910a5c to 09a3db9 Compare April 25, 2019 13:21
@k0kubun k0kubun force-pushed the irb-syntax-highlight branch from 09a3db9 to 48b2fd0 Compare April 25, 2019 14:37
pocket7878
pocket7878 reviewed Apr 25, 2019
View reviewed changes
lib/irb/color.rb Outdated Show resolved Hide resolved
pocket7878 and others added 2 commits April 25, 2019 23:47
@matzbot matzbot closed this in 94af6cd Apr 25, 2019
matzbot pushed a commit that referenced this pull request Apr 25, 2019
@k0kubun
Colorize IRB's inspect result
b55201d 
Closes: #2150
matzbot pushed a commit that referenced this pull request Apr 25, 2019
@pocket7878 @k0kubun
Do not color IRB output on 'dumb' TERM
022cbb2 
Co-Authored-By: k0kubun <takashikkbn@gmail.com>
Closes: #2150
matzbot pushed a commit that referenced this pull request Apr 25, 2019
@k0kubun
Force IRB::Color to recognize TERM
0c54d2e 
Closes: #2150
@k0kubun k0kubun deleted the irb-syntax-highlight branch April 25, 2019 15:49
matzbot pushed a commit that referenced this pull request Apr 25, 2019
@k0kubun
Add NEWS entry about IRB syntax highlight [ci skip]
e64bab5 
Details: #2150

Note that this introduction is discussed with @aycabta who is allowed to
make some changes to IRB by the IRB maintainer, keiju.
k0kubun added a commit to k0kubun/irb that referenced this pull request Apr 26, 2019
@k0kubun
Backport ruby/ruby#2150 from trunk
27f95b5
k0kubun added a commit to k0kubun/irb that referenced this pull request Apr 26, 2019
@k0kubun
Backport ruby/ruby#2150 from trunk
a0c4b38
k0kubun added a commit to k0kubun/irb that referenced this pull request Apr 26, 2019
@k0kubun
Backport ruby/ruby#2150 from trunk
a59ac3d
@k0kubun k0kubun mentioned this pull request Apr 26, 2019
Merged
k0kubun added a commit to k0kubun/irb that referenced this pull request Apr 26, 2019
@k0kubun
Backport ruby/ruby#2150 from trunk
020ea75
k0kubun added a commit to ruby/irb that referenced this pull request Apr 26, 2019
@k0kubun
Merge pull request #15 from k0kubun/backport-ruby-2150
e6739d8 
Backport ruby/ruby#2150 from trunk
aycabta pushed a commit to aycabta/irb that referenced this pull request Jun 6, 2019
@k0kubun @aycabta
Backport ruby/ruby#2150 from trunk
fd48596
@hsbt hsbt added the Backport label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocket7878 pocket7878 pocket7878 left review comments

Assignees
No one assigned
Labels
Backport
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k0kubun @pocket7878 @hsbt
0